708780cab9
- Imported last updates from v8. - Adapted to v9. - Added a saner default to `mass_mailing.salt` configuration parameter by reusing `database.secret` if available, hoping that some day https://github.com/odoo/odoo/pull/12040 gets merged. - Updated README. - Increase security, drop backwards compatibility. Security got improved upstream, which would again break compatibility among current addon and future master upstream. I choose to break it now and keep it secured future-wise, so I drop the backwards compatibility features. - Includes tour tests. - Removes outdated tests. - Extends the mailing list management form when unsubscriber is a contact. - Adds a reason form even if he is not. - Avoids all methods that were not model-agnostic. [FIX][mass_mailing_custom_unsubscribe] Reasons noupdate After this fix, when you update the addon, you will not lose your customized reasons. [FIX] Compatibilize with mass_mailing_partner Current test code was based on the assumption that the `@api.model` decorator on `create()` ensured an empty recordset when running the method, but that's not true. This was causing an incompatibility betwee these tests and the `mass_mailing_partner` addon, which works assuming 0-1 recordsets. Now records are created from an empty recordset, and thus tests work everywhere. Update instructions If the user does not add the unsubscribe snippet, nothing will happen, so it's added to README to avoid confusion when testing/using the addon. [FIX] Use the right operator to preserve recordsets order Using `|=` sorts records at will each time (treating them as Python's `set`). Using `+=` always appends a record to the end of the set. Since we are using the record position in the set, this caused the test to work sometimes and fail other times. Now it works always.
72 lines
2.2 KiB
Python
72 lines
2.2 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Copyright 2016 Jairo Llopis <jairo.llopis@tecnativa.com>
|
|
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
|
|
|
|
from openerp import _, api, fields, models
|
|
from .. import exceptions
|
|
|
|
|
|
class MailUnsubscription(models.Model):
|
|
_name = "mail.unsubscription"
|
|
_inherit = "mail.thread"
|
|
_rec_name = "date"
|
|
|
|
date = fields.Datetime(
|
|
default=lambda self: self._default_date(),
|
|
required=True)
|
|
email = fields.Char(
|
|
required=True)
|
|
mass_mailing_id = fields.Many2one(
|
|
"mail.mass_mailing",
|
|
"Mass mailing",
|
|
required=True,
|
|
help="Mass mailing from which he was unsubscribed.")
|
|
unsubscriber_id = fields.Reference(
|
|
lambda self: self._selection_unsubscriber_id(),
|
|
"Unsubscriber",
|
|
required=True,
|
|
help="Who was unsubscribed.")
|
|
reason_id = fields.Many2one(
|
|
"mail.unsubscription.reason",
|
|
"Reason",
|
|
ondelete="restrict",
|
|
required=True,
|
|
help="Why the unsubscription was made.")
|
|
details = fields.Char(
|
|
help="More details on why the unsubscription was made.")
|
|
details_required = fields.Boolean(
|
|
related="reason_id.details_required")
|
|
|
|
@api.model
|
|
def _default_date(self):
|
|
return fields.Datetime.now()
|
|
|
|
@api.model
|
|
def _selection_unsubscriber_id(self):
|
|
"""Models that can be linked to a ``mail.mass_mailing``."""
|
|
return self.env["mail.mass_mailing"]._get_mailing_model()
|
|
|
|
@api.multi
|
|
@api.constrains("details", "reason_id")
|
|
def _check_details_needed(self):
|
|
"""Ensure details are given if required."""
|
|
for one in self:
|
|
if not one.details and one.details_required:
|
|
raise exceptions.DetailsRequiredError(
|
|
_("Please provide details on why you are unsubscribing."))
|
|
|
|
|
|
class MailUnsubscriptionReason(models.Model):
|
|
_name = "mail.unsubscription.reason"
|
|
_order = "sequence, name"
|
|
|
|
name = fields.Char(
|
|
index=True,
|
|
translate=True,
|
|
required=True)
|
|
details_required = fields.Boolean(
|
|
help="Check to ask for more details when this reason is selected.")
|
|
sequence = fields.Integer(
|
|
index=True,
|
|
help="Position of the reason in the list.")
|