Yaltik/social
2
0
Fork 0
Code Pull Requests Releases Activity

[FIX] mail_tracking: do not warn not found if already opened

Browse Source 
The state will be 'opened' after first time email is opened. Each
successive open triggered warning, because state was already 'opened'
and thus did not match domain state in (sent, delivered).

Forward-port #d9ad3464
This commit is contained in:
Uku Lagle 2020-03-30 19:41:27 +03:00 committed by Jasmin Solanki
parent a85b2cb53b
commit 2718b80146
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
mail_tracking/controllers/main.py
View File

@ -81,18 +81,14 @@ class MailTrackingController(MailController):
with db_env(db) as env: with db_env(db) as env:
try: try:
tracking_email = env["mail.tracking.email"].search( tracking_email = env["mail.tracking.email"].search(
[ [("id", "=", tracking_email_id), ("token", "=", token)]
("id", "=", tracking_email_id),
("state", "in", ["sent", "delivered"]),
("token", "=", token),
]
) )
if tracking_email: if not tracking_email:
tracking_email.event_create("open", metadata)
else:
_logger.warning( _logger.warning(
"MailTracking email '%s' not found", tracking_email_id "MailTracking email '%s' not found", tracking_email_id
) )
elif tracking_email.state in ("sent", "delivered"):
tracking_email.event_create("open", metadata)
except Exception: except Exception:
pass pass