From b1df5d14285fb0643b22dddc245102b25434bfd1 Mon Sep 17 00:00:00 2001
From: Kodi Arfer <git@arfer.net>
Date: Sat, 4 Feb 2017 09:18:22 -0800
Subject: [PATCH] Remove extra uses of `let` in native_tests.language

Tests of `let` itself remain.
---
 tests/native_tests/language.hy | 218 ++++++++++++++++-----------------
 1 file changed, 109 insertions(+), 109 deletions(-)

diff --git a/tests/native_tests/language.hy b/tests/native_tests/language.hy
index 3d5124c..550db13 100644
--- a/tests/native_tests/language.hy
+++ b/tests/native_tests/language.hy
@@ -449,51 +449,51 @@
   (try (do) (except [IOError]) (except))
 
   ;; Test correct (raise)
-  (let [passed False]
-    (try
-     (try
-      (raise IndexError)
-      (except [IndexError] (raise)))
-     (except [IndexError]
-       (setv passed True)))
-    (assert passed))
+  (setv passed False)
+  (try
+   (try
+    (raise IndexError)
+    (except [IndexError] (raise)))
+   (except [IndexError]
+     (setv passed True)))
+  (assert passed)
 
   ;; Test incorrect (raise)
-  (let [passed False]
-    (try
-     (raise)
-     ;; Python 2 raises TypeError
-     ;; Python 3 raises RuntimeError
-     (except [[TypeError RuntimeError]]
-       (setv passed True)))
-    (assert passed))
+  (setv passed False)
+  (try
+   (raise)
+   ;; Python 2 raises TypeError
+   ;; Python 3 raises RuntimeError
+   (except [[TypeError RuntimeError]]
+     (setv passed True)))
+  (assert passed)
 
   ;; Test (finally)
-  (let [passed False]
-    (try
-     (do)
-     (finally (setv passed True)))
-    (assert passed))
+  (setv passed False)
+  (try
+   (do)
+   (finally (setv passed True)))
+  (assert passed)
 
   ;; Test (finally) + (raise)
-  (let [passed False]
-    (try
-     (raise Exception)
-     (except)
-     (finally (setv passed True)))
-    (assert passed))
+  (setv passed False)
+  (try
+   (raise Exception)
+   (except)
+   (finally (setv passed True)))
+  (assert passed)
 
 
   ;; Test (finally) + (raise) + (else)
-  (let [passed False
-        not-elsed True]
-    (try
-     (raise Exception)
-     (except)
-     (else (setv not-elsed False))
-     (finally (setv passed True)))
-    (assert passed)
-    (assert not-elsed))
+  (setv passed False
+        not-elsed True)
+  (try
+   (raise Exception)
+   (except)
+   (else (setv not-elsed False))
+   (finally (setv passed True)))
+  (assert passed)
+  (assert not-elsed)
 
   (try
    (raise (KeyError))
@@ -553,37 +553,37 @@
      (setv foobar42ofthebaz 42)
      (assert (= foobar42ofthebaz 42))))
 
-  (let [passed False]
-    (try
-     (try (do) (except) (else (bla)))
-     (except [NameError] (setv passed True)))
-    (assert passed))
+  (setv passed False)
+  (try
+   (try (do) (except) (else (bla)))
+   (except [NameError] (setv passed True)))
+  (assert passed)
 
-  (let [x 0]
-    (try
-     (raise IOError)
-     (except [IOError]
-       (setv x 45))
-     (else (setv x 44)))
-    (assert (= x 45)))
+  (setv x 0)
+  (try
+   (raise IOError)
+   (except [IOError]
+     (setv x 45))
+   (else (setv x 44)))
+  (assert (= x 45))
 
-  (let [x 0]
-    (try
-     (raise KeyError)
-     (except []
-       (setv x 45))
-     (else (setv x 44)))
-    (assert (= x 45)))
+  (setv x 0)
+  (try
+   (raise KeyError)
+   (except []
+     (setv x 45))
+   (else (setv x 44)))
+  (assert (= x 45))
 
-  (let [x 0]
-    (try
-     (try
-      (raise KeyError)
-      (except [IOError]
-        (setv x 45))
-      (else (setv x 44)))
-     (except))
-    (assert (= x 0))))
+  (setv x 0)
+  (try
+   (try
+    (raise KeyError)
+    (except [IOError]
+      (setv x 45))
+    (else (setv x 44)))
+   (except))
+  (assert (= x 0)))
 
 (defn test-earmuffs []
   "NATIVE: Test earmuffs"
@@ -677,9 +677,9 @@
 (defn test-yield-in-try []
   "NATIVE: test yield in try"
   (defn gen []
-    (let [x 1]
+    (setv x 1)
     (try (yield x)
-         (finally (print x)))))
+         (finally (print x))))
   (setv output (list (gen)))
   (assert (= [1] output)))
 
@@ -747,17 +747,17 @@
 
 (defn test-for-else []
   "NATIVE: test for else"
-  (let [x 0]
-    (for* [a [1 2]]
-      (setv x (+ x a))
-      (else (setv x (+ x 50))))
-    (assert (= x 53)))
+  (setv x 0)
+  (for* [a [1 2]]
+    (setv x (+ x a))
+    (else (setv x (+ x 50))))
+  (assert (= x 53))
 
-  (let [x 0]
-    (for* [a [1 2]]
-      (setv x (+ x a))
-      (else))
-    (assert (= x 3))))
+  (setv x 0)
+  (for* [a [1 2]]
+    (setv x (+ x a))
+    (else))
+  (assert (= x 3)))
 
 
 (defn test-list-comprehensions []
@@ -921,35 +921,36 @@
 
 (defn test-symbol-utf-8 []
   "NATIVE: test symbol encoded"
-  (let [♥ "love"
-        ⚘ "flower"]
-    (assert (= (+ ⚘ ♥) "flowerlove"))))
+  (setv ♥ "love"
+        ⚘ "flower")
+  (assert (= (+ ⚘ ♥) "flowerlove")))
 
 
 (defn test-symbol-dash []
   "NATIVE: test symbol encoded"
-  (let [♥-♥ "doublelove"
-        -_- "what?"]
-    (assert (= ♥-♥ "doublelove"))
-    (assert (= -_- "what?"))))
+  (setv ♥-♥ "doublelove"
+        -_- "what?")
+  (assert (= ♥-♥ "doublelove"))
+  (assert (= -_- "what?")))
 
 
 (defn test-symbol-question-mark []
   "NATIVE: test foo? -> is_foo behavior"
-  (let [foo? "nachos"]
-    (assert (= is_foo "nachos"))))
+  (setv foo? "nachos")
+  (assert (= is_foo "nachos")))
 
 
 (defn test-and []
   "NATIVE: test the and function"
-  (let [and123 (and 1 2 3)
+  
+  (setv and123 (and 1 2 3)
         and-false (and 1 False 3)
         and-true (and)
-        and-single (and 1)]
-    (assert (= and123 3))
-    (assert (= and-false False))
-    (assert (= and-true True))
-    (assert (= and-single 1)))
+        and-single (and 1))
+  (assert (= and123 3))
+  (assert (= and-false False))
+  (assert (= and-true True))
+  (assert (= and-single 1))
   ; short circuiting
   (setv a 1)
   (and 0 (setv a 2))
@@ -980,16 +981,16 @@
 
 (defn test-or []
   "NATIVE: test the or function"
-  (let [or-all-true (or 1 2 3 True "string")
+  (setv or-all-true (or 1 2 3 True "string")
         or-some-true (or False "hello")
         or-none-true (or False False)
         or-false (or)
-        or-single (or 1)]
-    (assert (= or-all-true 1))
-    (assert (= or-some-true "hello"))
-    (assert (= or-none-true False))
-    (assert (= or-false None))
-    (assert (= or-single 1)))
+        or-single (or 1))
+  (assert (= or-all-true 1))
+  (assert (= or-some-true "hello"))
+  (assert (= or-none-true False))
+  (assert (= or-false None))
+  (assert (= or-single 1))
   ; short circuiting
   (setv a 1)
   (or 1 (setv a 2))
@@ -1107,17 +1108,16 @@
 (defn test-eval-globals []
   "NATIVE: test eval with explicit global dict"
   (assert (= 'bar (eval (quote foo) {'foo 'bar})))
-  (assert (= 1 (let [d {}] (eval '(setv x 1) d) (eval (quote x) d))))
-  (let [d1 {}
-        d2 {}]
-    (eval '(setv x 1) d1)
-    (try
-      (do
-         ; this should fail with a name error
-         (eval (quote x) d2)
-         (assert False "We shouldn't have arrived here"))
-      (except [e Exception]
-        (assert (isinstance e NameError))))))
+  (assert (= 1 (do (setv d {}) (eval '(setv x 1) d) (eval (quote x) d))))
+  (setv d1 {}  d2 {})
+  (eval '(setv x 1) d1)
+  (try
+    (do
+       ; this should fail with a name error
+       (eval (quote x) d2)
+       (assert False "We shouldn't have arrived here"))
+    (except [e Exception]
+      (assert (isinstance e NameError)))))
 
 (defn test-eval-failure []
   "NATIVE: test eval failure modes"