4e15e63732
When calling `_next()` in a sequence, it issues calls to `search()`, especially if it is a no-gap or date-range-based sequence (which is common in this use case). When doing a search, Odoo triggers recomputations. Thus, when doing both a write and a call to `_next()` in the same loop, Odoo had to flush to DB too often, causing a bottleneck. Now, the process is more optimized: 1. Cache all new entry numbers. 2. Write them all. 3. Mark them all as modified at once, to batch-trigger recomputations. To reduce the amount of recomputations, tracking is disabled for the entry number. After all, before renumbering there's already a warning telling you that you shouldn't renumber if you already published those entry numbers to your fiscal authority. Another pseudo-improvement is that the info log is shorter. Enable debug logging to log the list of IDs changed. A test was failing because it was relying on the fact that computations were not getting as lazy as they should. Manual flushes are added to imitate a user doing different invoice creations. @moduon MT-3082
91 lines
3.7 KiB
Python
91 lines
3.7 KiB
Python
# Copyright 2022 Moduon
|
|
# License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl.html).
|
|
from freezegun import freeze_time
|
|
|
|
from odoo.tests.common import Form, new_test_user, tagged, users
|
|
from odoo.tools import mute_logger
|
|
|
|
from odoo.addons.account.tests.common import TestAccountReconciliationCommon
|
|
|
|
|
|
@freeze_time("2022-05-11", tick=True)
|
|
@tagged("post_install", "-at_install")
|
|
class RenumberCase(TestAccountReconciliationCommon):
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
super().setUpClass()
|
|
cls.invoicer = new_test_user(
|
|
cls.env, "test_invoicer", "account.group_account_invoice"
|
|
)
|
|
cls.manager = new_test_user(
|
|
cls.env, "test_manager", "account.group_account_manager"
|
|
)
|
|
|
|
@users("test_invoicer")
|
|
def test_invoice_gets_entry_number(self):
|
|
# Draft invoice without entry number
|
|
invoice = self._create_invoice()
|
|
self.assertFalse(invoice.entry_number)
|
|
# Gets one once posted
|
|
invoice.action_post()
|
|
self.assertTrue(invoice.entry_number.startswith("2022/"))
|
|
# Lost number when canceled
|
|
with mute_logger(
|
|
"odoo.addons.account_journal_general_sequence.models.account_move"
|
|
):
|
|
invoice.button_cancel()
|
|
self.assertFalse(invoice.entry_number)
|
|
|
|
@users("test_manager")
|
|
def test_renumber(self):
|
|
# Post invoices in wrong order
|
|
next_year_invoice = self._create_invoice(
|
|
date_invoice="2023-12-31", auto_validate=True
|
|
)
|
|
next_year_invoice.flush(["entry_number"], next_year_invoice)
|
|
new_invoice = self._create_invoice(
|
|
date_invoice="2022-05-10", auto_validate=True
|
|
)
|
|
new_invoice.flush(["entry_number"], new_invoice)
|
|
old_invoice = self._create_invoice(
|
|
date_invoice="2022-04-30", auto_validate=True
|
|
)
|
|
old_invoice.flush(["entry_number"], old_invoice)
|
|
self.assertLess(new_invoice.entry_number, old_invoice.entry_number)
|
|
# Fix entry number order with wizard; default values are OK
|
|
wiz_f = Form(self.env["account.move.renumber.wizard"])
|
|
self.assertEqual(len(wiz_f.available_sequence_ids), 1)
|
|
wiz = wiz_f.save()
|
|
wiz.action_renumber()
|
|
self.assertGreater(new_invoice.entry_number, old_invoice.entry_number)
|
|
# Add opening move
|
|
opening_invoice = self._create_invoice(
|
|
date_invoice="2022-01-01", auto_validate=True
|
|
)
|
|
self.assertGreater(opening_invoice.entry_number, new_invoice.entry_number)
|
|
# Renumber again, starting from zero
|
|
wiz_f = Form(self.env["account.move.renumber.wizard"])
|
|
wiz = wiz_f.save()
|
|
wiz.action_renumber()
|
|
self.assertEqual(opening_invoice.entry_number, "2022/0000000001")
|
|
self.assertEqual(old_invoice.entry_number, "2022/0000000002")
|
|
self.assertEqual(new_invoice.entry_number, "2022/0000000003")
|
|
self.assertEqual(next_year_invoice.entry_number, "2023/0000000001")
|
|
|
|
@users("test_invoicer")
|
|
def test_install_no_entry_number(self):
|
|
"""No entry numbers assigned on module installation."""
|
|
# Imitate installation environment
|
|
self.env = self.env(
|
|
context=dict(self.env.context, module="account_journal_general_sequence")
|
|
)
|
|
self.env["ir.module.module"].sudo().search(
|
|
[("name", "=", "account_journal_general_sequence")]
|
|
).state = "to install"
|
|
# Do some action that would make the move get an entry number
|
|
invoice = self._create_invoice()
|
|
self.assertFalse(invoice.entry_number)
|
|
invoice.action_post()
|
|
# Ensure there's no entry number
|
|
self.assertFalse(invoice.entry_number)
|