2
0
Commit Graph

37 Commits

Author SHA1 Message Date
Luc De Meyer
e4796d3bd5 [IMP] account_asset_management: Add reporting 2022-12-24 00:42:22 +01:00
JordiMForgeFlow
0d332ba006 [13.0][account_asset_management]: add user error when creating asset from bill 2022-12-24 00:42:22 +01:00
Víctor Martínez
4e31113bbe [FIX] account_asset_management: Fix onchange account_id and asset_profile_id to prevent account_id is empty in some use cases 2022-12-24 00:42:22 +01:00
Pedro M. Baeza
1620d3a4d8 [FIX] account_asset_management: Missing field renaming
type > move_type, due to uncovered code.
2022-12-24 00:42:22 +01:00
João Marques
dd7e4e08df [MIG] account_asset_management: Migration to v14
TT26410
2022-12-24 00:42:21 +01:00
Pedro M. Baeza
2aa11d4e40 [FIX] account_asset_management: Proper asset unlink + move unlink
2 related fixes:

- When removing an asset line depreciation move, we have to pass it
  first to draft, or we won't be able to remove it even with the
  context.
- When removing a move, the check for removing the linked asset should
  be only for purchase documents, not for "not sale" documents.
2022-12-24 00:42:21 +01:00
Florent de Labarre
3945771c61 [FIX] account_asset_management : empty message is posted if there are no asset 2022-12-24 00:42:21 +01:00
Pedro M. Baeza
2b360a8c27 [IMP] account_asset_management: Refinements 2022-12-24 00:42:21 +01:00
Carlos Dauden
389d82839e [IMP] account_asset_management: Improve code and translation 2022-12-24 00:42:21 +01:00
Saran440
869cc39d5e [FIX] account_asset_management - Allow editing salvage value 2022-12-24 00:42:21 +01:00
Valentin Vinagre Urteaga
9f9a72f073 [FIX] account_asset_management: FIX empty asset reference
If the assets are created before posting the invoice, they wouldn't have a name and the "code" field of the assets will be empty, but they would have the invoice name.
2022-12-24 00:42:21 +01:00
Ernesto Tejeda
a555ed9259 [FIX] account_asset_management: fix remaining_value cache miss error. 2022-12-24 00:42:21 +01:00
Valentin Vinagre Urteaga
009b0b494a [IMP] account_asset_management: Add chatter entry in invoice for generated asset 2022-12-24 00:42:21 +01:00
Andrea
91f989be0e Fix of pre-commit: E741 ambiguous variable name 'l' 2022-12-24 00:42:21 +01:00
Quentin Groulard
e53bd5b26e [IMP] account_asset_management: Depreciation board compute upon asset confirmation 2022-12-24 00:42:21 +01:00
Pedro M. Baeza
20078b4472 [IMP] account_asset_management: Simplify code for opening related entries
We don't need the search having the one2many field and no need also for list
comprehension having mapped operator.
2022-12-24 00:42:21 +01:00
Pedro M. Baeza
a16a456511 [FIX] account_asset_management: Avoid error
Steps to reproduce the problem:

* Go to assets view
* Group by profile
* Unfold a group and click on an asset
* Click on "Journal Entries" smart-button
* Go back to the asset list
* Click again on the same asset (or another).
* Click on "Journal Entries" smart-button

Current behavior:

Error saying "KeyError: 'profile_id'"

Expected behavior:

No error

The cause for this is that Odoo stores in the context the key `group_by` with the
value `profile_id` in the specified chain of steps. That context entry is used for
grouping records in the list, and system tries to group the journal entries also
by that field, which doesn't exists in the other model, and thus the error.

We avoided it copying the context to be passes and leaving out that entry.
2022-12-24 00:42:21 +01:00
ernestotejeda
7e9d38ef5e [MIG] account_asset_management: Migration to 13.0 2022-12-24 00:42:21 +01:00
ernestotejeda
bc3e0f8fa6 [IMP] account_asset_management: black, isort 2022-12-24 00:42:21 +01:00
Luc De Meyer
cd3bd6bbd2 [12.0][FIX]traceback when deviating FY 2022-12-24 00:42:21 +01:00
Iván Todorovich
6673fcab25 [12.0][FIX][account_asset_management] local variable 'asset' referenced before assignment
tools/account_asset_management/models/account_asset.py", line 970, in _compute_entries
    % (asset.name, asset.code) or asset.name
UnboundLocalError: local variable 'asset' referenced before assignment
2022-12-24 00:42:21 +01:00
Joan Sisquella
f8af00f03a [ADD] allows setting a depreciation ending date 2022-12-24 00:42:21 +01:00
Saran
bbe959c783 [ADD] options 'use_leap_years' 2022-12-24 00:42:21 +01:00
Saran
181d7f2f83 [12.0][IMP] account_asset_management 2022-12-24 00:42:21 +01:00
Pedro M. Baeza
dab2a897b4 [MIG+FIX+IMP] account_asset_management: Rework migration scripts + make asset group m2m 2022-12-24 00:42:21 +01:00
Henrik Norlin
05e3fa1033 [IMP] removed type, parent_id, parent_path, child_ids from account.asset & account.asset.profile 2022-12-24 00:42:21 +01:00
Pedro M. Baeza
095a205ab1 [FIX] account_asset_management: Don't depend on account.fiscal.year created records
* There's no need of forcing to create such records if your fiscal years are regular ones.
* FY date range computation duplicates code that is already on core.
* DummyFY is a good idea, but was not used at all. Now it is.
2022-12-24 00:42:21 +01:00
Luc De Meyer
fabe61b412 [FIX][12.0]asset_management - fix date string compare 2022-12-24 00:42:21 +01:00
Pedro M. Baeza
68509d7386 [FIX] account_asset_management: Provide hook _compute_depreciation_amount_per_fiscal_year
This way, other method_time mechanism like localization ones is able to overwrite it.

You also got an error of variable `number` not set due to previous code. Although no
alternate implementation for a new method_time, now you don't have any error,
fallbacking to standard proportional repartition.
2022-12-24 00:42:21 +01:00
Henrik
61d5a0b076 [12.0][FIX] account_asset_management: date_range -> account_fiscal_year, account_analytic_id without domain 2022-12-24 00:42:21 +01:00
Bejaoui Souheil
8fa0de5226 Finish 12.0 migration of account_asset_management
* account_asset: Do not loop on all the lines to search for one linked asset

Before this change, the use of `mapped` on self did loop on all the move
lines that are included in self to get the assets, what could be very
costly for a simple write on a lot of move lines. As the goal is to raise
an error only if at least one move is linked to an asset, we break the
loop if the condition is fulfilled.

* performance improvement

* [RMV] - Remove useless dependency

In 12.0 account_fiscal_year is a standard feature no need to depend on oca
module account_fiscal_year
2022-12-24 00:42:21 +01:00
Maxence Groine
9ff14512da Included PR #828 Fix computation of depreciation lines when having multiple assets in invoice 2022-12-24 00:42:21 +01:00
Henrik Norlin
886abfe610 [MIG] account_asset_management: Migration to 12.0 2022-12-24 00:42:21 +01:00
Akim Juillerat
a7cdfdd14d [MIG] account_asset_management: Migration to 11.0 2022-12-24 00:42:20 +01:00
Luc De Meyer
49d1c36679 [FIX] account_asset_management: Test data + onchange 2022-12-24 00:42:20 +01:00
Akim Juillerat
163eb03e63 [FIX+IMP] account_asset_management: 2 things:
* Fix compute methods dependencies and small optimizations
* Rename demo file to test and move it into the right folder
2022-12-24 00:42:20 +01:00
Luc De Meyer
7c76c17231 [10.0][MIG]account_asset_management suite refactoring + 10.0 port 2022-12-24 00:42:20 +01:00