2
0
Commit Graph

58 Commits

Author SHA1 Message Date
OCA-git-bot
872df7890d Merge PR #1706 into 16.0
Signed-off-by pedrobaeza
2023-08-08 08:28:03 +00:00
Camille Morand
57f5e06097 [FIX][account_chart_update] Remove account tax browsing since already a recordset
todo_dict["account_dict"]["account.tax"].keys() are already records, not just ID, so we can use them directly. Trying to browse causes an error : `psycopg2.ProgrammingError: can't adapt type 'account.tax'`.
2023-08-04 08:48:57 +02:00
Pedro M. Baeza
7a4c341e3a [IMP] account_chart_update: Create account groups in batch
For improving performance.
2023-08-03 17:09:13 +02:00
Enric Tobella
7feba6312b [IMP] account_chart_update: Update account groups too 2023-08-03 17:09:06 +02:00
Lois Rilo
ed1730598d [FIX] account_chart_update: do not repartion in groups + do append False IDs
1) In tax groups repartition lines are not used, however when creating
tax groups from templates the default repartition lines are created.
If you run the chart update again, it will detect those "useless"
default repartition lines and mark them to removal, raising an
error when trying to do so as a minial of 2 repartition lines are
needed (on base and one tax).

2) When matching taxes, if not match, do not add `False` to the list.
2023-07-12 11:06:04 +02:00
Luis J. Salvatierra
e5151026a5 [MIG] account_chart_update: Migration to 16.0 2023-01-30 09:26:38 +01:00
Jairo Llopis
79bbd7cdc4 [FIX] account_chart_update: false positive detecting diff on Html fields
When executing the chart updater and selecting the "notes" field from fiscal positions, you were getting differences 100% of the time.

This was because [fiscal position's notes field is Html][1], while [the template field is Text][2].

@moduon MT-1912

[1]: 5ef647d5d4/addons/account/models/partner.py (L32)
[2]: 5ef647d5d4/addons/account/models/chart_template.py (L1470)
2023-01-17 08:54:49 +01:00
Jairo Llopis
bcef995ecc [FIX] account_chart_update: responsive views
Make its 2nd step usable.

@moduon MT-1923
2023-01-17 08:54:49 +01:00
Lois Rilo
c630022abf [IMP] account_chart_update: improve extensibility 2023-01-17 08:54:49 +01:00
Pedro M. Baeza
934e2e57f6 [FIX] account_chart_update: Incorrect call in find account method
Clear copy/paste error.
2023-01-17 08:54:49 +01:00
manu
b39b008b11 [15.0][FIX] account_chart_update: do not browse rep_line in _update_taxes_pending_for_accounts 2023-01-17 08:54:49 +01:00
Fernando La Chica
7fa493cf91 Migration and some fixes:
* Ignore changes in mail thread fields
   * account.tax.template._generate_tax return dict of objects
     and wizard fails
   * Load generic coa localization module to improve the test
2023-01-17 08:54:49 +01:00
Lois Rilo
236a764c99 [FIX] account_chart_update: do not match twice the same repartition line
When updating a tax with several repartition lines, the same existing
candidates were considered in all iteration which could lead the wizard
to match the same repartition line with different lines of the template
and not detecting any change to do.
2023-01-17 08:54:49 +01:00
Miquel Raïch
8beac87a40 [FIX] account_loan: post() -> action_post() 2023-01-17 08:54:49 +01:00
Miquel Raïch
320079d543 [FIX] account_chart_update: Warning -> UserError 2023-01-17 08:54:49 +01:00
Pedro M. Baeza
63435fbbed [FIX] account_chart_update: cash_basis_base_account_id no longer exists
This field disappears in this version.
2023-01-17 08:54:49 +01:00
Luc De Meyer
7a7f0f447c [13.0][FIX]account_chart_update refactor tax update 2023-01-17 08:54:49 +01:00
Luc De Meyer
eefe80e215 [FIX] account_chart_update: ignore template fields that do not exist in real 2023-01-17 08:54:49 +01:00
Reyes4711
d4094eff87 [14.0][MIG] account_chart_update: Migration to 14.0 2023-01-17 08:54:49 +01:00
Luc De Meyer
5662dfe483 [13.0][FIX]account_chart_update inactive taxes false positives 2023-01-17 08:54:49 +01:00
Pedro M. Baeza
2ec48c4fea [IMP] account_chart_update: Search for real XML-IDs only
Previously, only a check on an existing XML-ID which is not coming from exportation
was done, but now we check that the XML-ID is the exact one. With this, we avoid
that the same record changed their XML-ID and thus, there's no more link between
them.
2023-01-17 08:54:49 +01:00
ps-tubtim
ac2034c28b [13.0][FIX] account_chart_update: Remove @api.multi 2023-01-17 08:54:49 +01:00
Pedro M. Baeza
ad1b376b89 [FIX+IMP] account_chart_update: Add consistency method
With this, we prevent lock due to infinite loop if children taxes are matched, but
not the parent one and it's marked to be created.
2023-01-17 08:54:49 +01:00
Pedro M. Baeza
d8644c16a3 [FIX+IMP] account_chart_update: Create taxes in batch
With this, we gain some performance, but also prevent an error if there are template
taxes that have children taxes, as Odoo standard method forces that in the same call
all of them are created simultaneously, or it will enter in an infinite loop.
2023-01-17 08:54:49 +01:00
OCA-git-bot
98fd1e8c65 pre-commit update 2023-01-17 08:54:49 +01:00
Pedro M. Baeza
7f4622bb9b [FIX] account_chart_update: Clear caches before searching
If not, changes done in for example taxes are not reflected.
2023-01-17 08:54:49 +01:00
ernestotejeda
f20f692994 [MIG] account_chart_update: Migration to 13.0 2023-01-17 08:54:49 +01:00
ernestotejeda
2e7396b485 [IMP] account_chart_update: black, isort 2023-01-17 08:54:49 +01:00
ernesto
4bf18c89b7 [MIG] account_chart_update: Migration to 12.0 2023-01-17 08:54:49 +01:00
ernesto
7c03d64afc account_chart_update: Fix number of updates and insertions in log 2023-01-17 08:54:49 +01:00
ernesto
203c45b253 account_chart_update: allows to set the matching value order
It allows to set the order of matching for Account, Taxes and
Fiscal position.
2023-01-17 08:54:49 +01:00
Pedro M. Baeza
9e63f90527 [IMP] account_chart_update: Include field selection
With this option, you can select which fields do you want to compare for updating.

Use case: you have specific accounts in taxes, and you don't want to lose them,
but you want to update their groups through the wizard. Before this, the update
was all or nothing. Now, you have total control!
2023-01-17 08:54:49 +01:00
Pedro M. Baeza
e206a37bdd [FIX] account_chart_update: Handle updated m2m correctly 2023-01-17 08:54:49 +01:00
Pedro M. Baeza
768276e964 [MIG] account_chart_update: Additional needed changes 2023-01-17 08:54:49 +01:00
amcor
c564971dbf [MIG] account_chart_update: Migration to 11.0 2023-01-17 08:54:49 +01:00
Stéphane Bidoul (ACSONE)
4b597e417c account_chart_update: copy inactive tax templates too
In v10, tax templates have an active flag. It is useful to copy them too, letting the user select which one he wants to activate in it's instance.
2023-01-17 08:54:49 +01:00
Pedro M. Baeza
f833ccdf36 [FIX+IMP] account_chart_update: Major refactoring
* Compare all fields from template

  Not all fields were properly compared with previous code. This means also
  to exclude some of them, but now we have a full and extensible system.

* Optimize cached method
* Generate accounts and fiscal positions using Odoo methods (tax already did)
* README by fragments
* Add tests up to full coverage
2023-01-17 08:54:49 +01:00
Pedro M. Baeza
7c52e09c8d [FIX] account_chart_update: Don't cache recordsets
When marking methods as ormcache, you can't return recordsets, as they keep
the cursor information, and that cursor can be closed (worker spawn for example)
when you need to access again data.

This is fixed returning IDs instead, and browsing when needed
2023-01-17 08:54:49 +01:00
moutio
45e6abae56 [FIX] account_chart_update: Limit fiscal position search with same name (#651) 2023-01-17 08:54:49 +01:00
Pedro M. Baeza
cf714c11f8 [FIX] account_chart_update: Fetch account code digits correctly 2023-01-17 08:54:49 +01:00
Sylvain Van Hoof
7093779041 [MIG] account_chart_update: Migration to 10.0 2023-01-17 08:54:49 +01:00
Pedro M. Baeza
fa34bca71b [FIX+IMP] account_chart_update: Fix fiscal position mapping + translations + clean authors
As this module has been written from scratch with a totally different technique, I clean the list and update copyrights.
2023-01-17 08:54:49 +01:00
Jairo Llopis
88488fd5f1 [MIG][9.0][account_chart_update] Migrate.
- New-style license headers.
- Remove .pot file.
- Remove tax codes stuff, now removed from v9.
- Refactor methods for search, create, update, delete. Now they are smaller, fitter, happier, more productive.
- Only update fields that have any kind of change on any updated record.
- Place the wizard in the configuration page, instead of its own menu item.
- Display amount of disabled taxes at ending page.
2023-01-17 08:54:49 +01:00
Stéphane Bidoul
4c5b816db3 [FIX] account_chart_update:
* Process price_include field
* Detect change in price_include field
2023-01-17 08:54:49 +01:00
PabloCM
b09acad132 [FIX] Include acc templates from parent CoA templates 2023-01-17 08:54:49 +01:00
Pedro M. Baeza
a560d62acd [FIX] account_chart_update: Don't write code on account update
As there's a constraint that forbids to write the code of the account
if it has moves, we delete the corresponding entry on update only,
because the method that prepares the values is the same for new and
existing accounts.
2023-01-17 08:54:49 +01:00
Pedro M. Baeza
f98233d55e [FIX] account_chart_update: Call mapping function instead of removed cache. Closes #240 2023-01-17 08:54:49 +01:00
Antonio Espinosa
317bb9f542 [FIX+IMP] account_chart_update: Several things
* Set updated taxes as active
* Check parent_id field in '_is_different_tax' method
* PEP8
* Spanish translation
2023-01-17 08:54:49 +01:00
Pedro M. Baeza
bc483a106f [IMP] account_chart_update: Whole refactoring
* Fix calculated field when showing inactives + add field to view
* Migrated to new API.
* Provided hooks for detecting changes and for adding update/create values.
* Purge dead error detection code (not applying).
* Use global mapping dictionaries stored on class instead of passing arguments down to top and viceversa.
* Number fields computed by a function field instead of being computed by hand.
* Use recordsets as indexes instead of ids to avoid repetitive browses.
* Re-enable local cache variables
* README + authors
2023-01-17 08:54:49 +01:00
Stéphane Bidoul
ef73f5ad50 [FIX+IMP] account_chart_update: Several things
* search on code first to match tax codes

  The tax code code should be more discriminant that the tax code name.

* compare more fields in tax codes
* deletion of tax codes removed from templates

  For tax codes, it make sense to propose deletion, since tax codes
  are normally defined by the tax authority and the user does not
  customize them.

* update accounts on taxes even if an update of the account was not requested

  Useful when the chart of taxes changes but the chart of account
  need not be updated.

* depth-first search of tax codes

  This helps creating parents before children.

* compare more fields in taxes
* add active field on tax code

  Deactivate tax codes which are not in the template.

* deactivate taxes that are not in the template
* multi-company criteria for taxes
* avoid inserting duplicates in presence of inactive taxes or tax codes
2023-01-17 08:54:49 +01:00