Yaltik/account-financial-tools
2
0
Fork 0
Code Pull Requests Activity

Finish 12.0 migration of account_asset_management

Browse Source 
* account_asset: Do not loop on all the lines to search for one linked asset

Before this change, the use of `mapped` on self did loop on all the move
lines that are included in self to get the assets, what could be very
costly for a simple write on a lot of move lines. As the goal is to raise
an error only if at least one move is linked to an asset, we break the
loop if the condition is fulfilled.

* performance improvement

* [RMV] - Remove useless dependency

In 12.0 account_fiscal_year is a standard feature no need to depend on oca
module account_fiscal_year
This commit is contained in:
Bejaoui Souheil 2019-06-20 19:19:51 +02:00 committed by Rodrigo
parent 9ff14512da
commit 8fa0de5226
3 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
account_asset_management/__manifest__.py
View File

@ -6,7 +6,7 @@
'version': '12.0.1.0.0', 'version': '12.0.1.0.0',
'license': 'AGPL-3', 'license': 'AGPL-3',
'depends': [ 'depends': [
'account_fiscal_year', 'account',
], ],
'excludes': ['account_asset'], 'excludes': ['account_asset'],
'author': "Noviat,Odoo Community Association (OCA)", 'author': "Noviat,Odoo Community Association (OCA)",

12
account_asset_management/models/account_move.py
View File

@ -116,15 +116,19 @@ class AccountMoveLine(models.Model):
@api.multi @api.multi
def write(self, vals): def write(self, vals):
if ( if (
self.mapped('asset_id') and
set(vals).intersection(FIELDS_AFFECTS_ASSET_MOVE_LINE) and set(vals).intersection(FIELDS_AFFECTS_ASSET_MOVE_LINE) and
not ( not (
self.env.context.get('allow_asset_removal') and self.env.context.get('allow_asset_removal') and
list(vals.keys()) == ['asset_id']) list(vals.keys()) == ['asset_id'])
): ):
raise UserError( # Check if at least one asset is linked to a move
_("You cannot change an accounting item " linked_asset = False
"linked to an asset depreciation line.")) for move in self:
linked_asset = move.asset_id
if linked_asset:
raise UserError(
_("You cannot change an accounting item "
"linked to an asset depreciation line."))
if vals.get('asset_id'): if vals.get('asset_id'):
raise UserError( raise UserError(
_("You are not allowed to link " _("You are not allowed to link "

2
account_asset_management/static/description/index.html
View File

@ -3,7 +3,7 @@
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"> <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head> <head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="generator" content="Docutils 0.14: http://docutils.sourceforge.net/" /> <meta name="generator" content="Docutils 0.15.1: http://docutils.sourceforge.net/" />
<title>Assets Management</title> <title>Assets Management</title>
<style type="text/css"> <style type="text/css">