From 20078b4472fcc7a2093344920bbd7bbba034f14f Mon Sep 17 00:00:00 2001 From: "Pedro M. Baeza" Date: Wed, 18 Mar 2020 19:35:44 +0100 Subject: [PATCH] [IMP] account_asset_management: Simplify code for opening related entries We don't need the search having the one2many field and no need also for list comprehension having mapped operator. --- account_asset_management/models/account_asset.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/account_asset_management/models/account_asset.py b/account_asset_management/models/account_asset.py index 084ab20a..f777cabd 100644 --- a/account_asset_management/models/account_asset.py +++ b/account_asset_management/models/account_asset.py @@ -490,10 +490,6 @@ class AccountAsset(models.Model): def open_entries(self): self.ensure_one() - amls = self.env["account.move.line"].search( - [("asset_id", "=", self.id)], order="date ASC" - ) - am_ids = [l.move_id.id for l in amls] # needed for avoiding errors after grouping in assets context = dict(self.env.context) context.pop("group_by", None) @@ -504,7 +500,7 @@ class AccountAsset(models.Model): "view_id": False, "type": "ir.actions.act_window", "context": context, - "domain": [("id", "in", am_ids)], + "domain": [("id", "in", self.account_move_line_ids.mapped("move_id").ids)], } def _group_lines(self, table):